-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline cache #663
Closed
Timeline cache #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix infinite loading. Remove spinner correctly. Don't refresh timeline without need.
Okay, let's track things
|
1 task
There is a new PR on this, rebased by charlag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is branched from the #562 )
This is PR aims to add kind of a an offline cache to the timelines. Something like Mastalab and Pinafore have.
It is a super tricky topic (cache invalidation, you know) but the potential benefit is huge.
I was surprised that I was able to make this initial implementation in a pretty efficient way (no N+1 requests, two JOINs).
The hardest part is reblogs. The easy way would be to seialize reblogged toot but I think I've came up with something much more efficient, see
TimelineStatusEntity
.We should thoughtfully discuss caching strategy. There's a wonderfully illustrated explanation on the topic. I'd say we use "cache than network". It would updating timeline two times but that's the hardest part, actual request race is trivial with Rx.
Another thing is that we should stop relying on headers for timeline paging because it's incompatible with offline caching.
Anyway, it's not ready but I would like to hear your feedback on this.