Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm produces different integrity hash for better-sqlite3 on windows, breaking CI build #3982

Closed
johnbotris opened this issue Mar 23, 2022 · 3 comments
Closed

npm produces different integrity hash for better-sqlite3 on windows, breaking CI build #3982

johnbotris opened this issue Mar 23, 2022 · 3 comments
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci)
Milestone
3.94.2

Comments

@johnbotris
Copy link
Contributor

johnbotris commented Mar 23, 2022 •
edited
Loading

When running npm ci on windows, a different integrity hash is produced for our fork of better-sqlite3 than the one that is in package-lock.json, which was generated on ubuntu, causing the integrity check to fail.

Running npm install -S better-sqlite3@github:tutao/better-sqlite3-sqlcipher#<the-same-commit-hash-as-in-package.json> will update the hash in package-lock.json, allowing a subsequent call to npm ci.

It's unclear to me why this happens, it could be a bug in npm on windows? It also produces a sha512 hash, just a different one
@johnbotris johnbotris added bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) labels Mar 23, 2022
@johnbotris johnbotris added this to the 3.94.1 milestone Mar 23, 2022
@johnbotris johnbotris reopened this Mar 23, 2022
@johnbotris
Copy link
Contributor Author

Found some issues which seem to be the same:

npm/pacote#76
npm/cli#2846

johnbotris added a commit that referenced this issue Mar 23, 2022
@johnbotris
[build] reinstall better-sqlite3 before running npm ci in windows
c543c24 
this is a workaround for #3982
@johnbotris
Copy link
Contributor Author

A potential solution would be to start using npm 8, as it no longer checks the integrity of git dependencies

@johnbotris
Copy link
Contributor Author

johnbotris commented Mar 24, 2022 •
edited
Loading

workaround fix: bfa2a08

charlag added a commit that referenced this issue Apr 5, 2022
@charlag
[ci] Use npm ci on Windows too, #3982
c27f0fd 
With new npm version git dependencies are handled correctly.
charlag added a commit that referenced this issue Apr 5, 2022
@charlag
[ci] Use npm ci on Windows too, #3982
493889e 
With new npm version git dependencies are handled correctly.
charlag added a commit that referenced this issue Apr 5, 2022
@charlag
[ci] Use npm ci on Windows too, #3982
a6b37cf 
With new npm version git dependencies are handled correctly.
sarashub pushed a commit that referenced this issue Apr 5, 2022
@charlag @sarashub
[ci] Use npm ci on Windows too, #3982
449df1f 
With new npm version git dependencies are handled correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci)
Projects
None yet
Milestone
3.94.2
Development

No branches or pull requests
1 participant
@johnbotris