Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deleting credentials when offline #5954

Closed
2 tasks
kibibytium opened this issue Oct 4, 2023 · 6 comments · Fixed by #7733
Closed
2 tasks

allow deleting credentials when offline #5954

kibibytium opened this issue Oct 4, 2023 · 6 comments · Fixed by #7733
Assignees
Labels
idea notes down not immediately solvable things that don't have general buy-in yet improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Milestone

Comments

@kibibytium
Copy link

kibibytium commented Oct 4, 2023

When offline, I cannot delete stored credentials. The client shows a connection error when clicking on delete.

As a user, I would like to be able to delete local credentials and see a notification that the session cannot be invalidated without an internet connection.

Tested on all native apps, v3.118.12

screenshot

image

Test notes

  • You can remove an account when online like normal
  • You can remove an account when offline
@kibibytium kibibytium added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues improvement nice-to-haves that are not impeding usage of any features and removed bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Oct 4, 2023
@charlag
Copy link
Contributor

charlag commented Oct 5, 2023

@kibhub this is as expected. We need to delete the session to delete the credentials. If we want to change this we need to discuss it.

@charlag charlag closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
@ganthern
Copy link
Contributor

ganthern commented Oct 5, 2023

@kibhub this is as expected. We need to delete the session to delete the credentials. If we want to change this we need to discuss it.

I think that was the point of opening the issue

@charlag
Copy link
Contributor

charlag commented Oct 5, 2023

I don't like labeling things that work as designed as bugs, it's very misleading.
If we want to change this we should bring it up to refinement or open it as "idea" or something like that.

@ganthern
Copy link
Contributor

ganthern commented Oct 5, 2023

it was not labeled as a bug though?

@charlag
Copy link
Contributor

charlag commented Oct 5, 2023

oh I misread that my bad

@charlag charlag reopened this Oct 5, 2023
@charlag charlag added the idea notes down not immediately solvable things that don't have general buy-in yet label Oct 5, 2023
@kibibytium kibibytium changed the title cannot delete credentials when offline allow deleting credentials when offline Oct 5, 2023
@kibibytium
Copy link
Author

@charlag the title was also a bit misleading. I think it is clearer now.

@BijinDev BijinDev self-assigned this Oct 15, 2024
BijinDev added a commit that referenced this issue Oct 15, 2024
Close #5954
Co-authored-by: ivk <ivk@tutao.de>
@wrdhub wrdhub linked a pull request Oct 15, 2024 that will close this issue
BijinDev added a commit that referenced this issue Oct 16, 2024
Close #5954
Co-authored-by: ivk <ivk@tutao.de>
@wrdhub wrdhub added this to the Next mail release milestone Oct 17, 2024
@wrdhub wrdhub closed this as completed Oct 18, 2024
wrdhub pushed a commit that referenced this issue Oct 18, 2024
Close #5954
Co-authored-by: ivk <ivk@tutao.de>
@andrehgdias andrehgdias self-assigned this Oct 21, 2024
@andrehgdias andrehgdias added the state:tested We tested it and are about to release it label Oct 21, 2024
jgoedde pushed a commit that referenced this issue Oct 28, 2024
Close #5954
Co-authored-by: ivk <ivk@tutao.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea notes down not immediately solvable things that don't have general buy-in yet improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants