Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgrammingError: Failed to remove overlay #6580

Closed
4 tasks done
charlag opened this issue Feb 20, 2024 · 1 comment · Fixed by #6597
Closed
4 tasks done

ProgrammingError: Failed to remove overlay #6580

charlag opened this issue Feb 20, 2024 · 1 comment · Fixed by #6597
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors no-repro bugs that don't have a reproduction yet state:done meets our definition of done state:tested We tested it and are about to release it uncaught-error an uncaught error that turned up in the reports mailbox.
Milestone
218.240227.0

Comments

@charlag
Copy link
Contributor

charlag commented Feb 20, 2024 •
edited
Loading 

Client: Browser
Tutanota version: 218.240219.0
User agent:
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0
ProgrammingError
Error message: Failed to remove overlay with key:3!
Stacktrace:
ProgrammingError. Failed to remove overlay with key:3!

Test Notes

  • Error report overlay still working
  • Offline snackBar still working
  • Minimized draft email popup still working
  • If you fast tap the close button of an overlay it doesn't throw an error
@charlag charlag added bug broken functionality, usability problems, unexpected errors no-repro bugs that don't have a reproduction yet labels Feb 20, 2024
@charlag
Copy link
Contributor Author

charlag commented Feb 20, 2024

My suggestion is to do some of the:

  • go over the usages of overlay and try to figure out where it is called twice
  • wrap it in makeSingleUse()
  • do not throw an error

@charlag charlag added the uncaught-error an uncaught error that turned up in the reports mailbox. label Feb 23, 2024
@murilopereirame murilopereirame self-assigned this Feb 23, 2024
murilopereirame added a commit that referenced this issue Feb 23, 2024
@murilopereirame
Make overlay close action singleUse
c0ba456 
fix #6580
@murilopereirame murilopereirame mentioned this issue Feb 23, 2024
Merged
murilopereirame added a commit that referenced this issue Feb 23, 2024
@murilopereirame
Make overlay close action singleUse
149c1fd 
fix #6580
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@murilopereirame @charlag
Make overlay close action singleUse
e47c87e 
fix #6580
@charlag charlag added the state:done meets our definition of done label Feb 26, 2024
murilopereirame added a commit that referenced this issue Feb 26, 2024
@murilopereirame
Make overlay close action singleUse
90ba676 
fix #6580
@charlag charlag added this to the 218.240226.0 milestone Feb 26, 2024
@charlag charlag assigned charlag and unassigned murilopereirame Feb 27, 2024
@charlag charlag added the state:tested We tested it and are about to release it label Feb 27, 2024
murilopereirame added a commit that referenced this issue Mar 1, 2024
@murilopereirame
Make overlay close action singleUse
e214793 
fix #6580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors no-repro bugs that don't have a reproduction yet state:done meets our definition of done state:tested We tested it and are about to release it uncaught-error an uncaught error that turned up in the reports mailbox.
Projects
None yet
Milestone
218.240227.0
Development

Successfully merging a pull request may close this issue.

Make overlay close action singleUse tutao/tutanota
2 participants
@charlag @murilopereirame