Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbing in the editor breaks navigation and templates #6759

Closed
3 of 4 tasks
paw-hub opened this issue Mar 20, 2024 · 0 comments · Fixed by #6760
Closed
3 of 4 tasks

Tabbing in the editor breaks navigation and templates #6759

paw-hub opened this issue Mar 20, 2024 · 0 comments · Fixed by #6760
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@paw-hub
Copy link
Contributor

paw-hub commented Mar 20, 2024

We recently received complaints about tabbing breaking templates.

Additionally, we have received complaints about tabbing breaking navigation, particularly for blind or otherwise visually impaired users who may tab into the mail editor but then may not be able to escape from it besides closing the mail or sending it.

The issue is because we add an em space when tab is pressed, and this was due to a previous commit that introduced this functionality and also fixed tabbing doing indentation.

We should just not insert an em space and let the editor work as it did before here (letting tab do the default behavior outside of indenting bullet points).

AC

  • Pressing tab/shift-tab in the editor does normal navigation except when the user is in a bullet point, in which case it will allow the user to shift the indentation level of that bullet point.

Test notes

  • Templates work (type # followed by a template name, and then press tab)
  • Navigation works (pressing tab/shift-tab escapes an empty mail editor)
  • Bullet point indentation works works (create a first level bullet point, type something, then press enter to create a second bullet, press tab to increase the indentation of this, and then shift-tab to reduce the indentation for this)
@paw-hub paw-hub added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Mar 20, 2024
paw-hub added a commit that referenced this issue Mar 20, 2024
Turns out this breaks navigation and templates.

Fixes #6759
@paw-hub paw-hub self-assigned this Mar 20, 2024
@murilopereirame murilopereirame added the state:done meets our definition of done label Mar 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
Turns out this breaks navigation and templates.

Fixes #6759

Co-authored-by: paw <paw-hub@users.noreply.github.com>
@murilopereirame murilopereirame self-assigned this Mar 27, 2024
@murilopereirame murilopereirame added the state:tested We tested it and are about to release it label Mar 27, 2024
@murilopereirame murilopereirame removed their assignment Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants