Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Sender Name doesn't work #7254

Closed
murilopereirame opened this issue Jul 22, 2024 · 2 comments · Fixed by #7728
Closed

Removing Sender Name doesn't work #7254

murilopereirame opened this issue Jul 22, 2024 · 2 comments · Fixed by #7728
Assignees
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone

Comments

@murilopereirame
Copy link
Contributor

Describe the bug
When setting the Sender Name to an empty string, the client doesn't return any error or warnings and restore what was set before.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings > Email
  2. Set the "Sender name" to an empty string
  3. Click again to change the sender name, see that the data wasn't erased.

Expected behavior
The sender name is empty.

@murilopereirame murilopereirame added the bug broken functionality, usability problems, unexpected errors label Jul 22, 2024
@rezbyte
Copy link
Contributor

rezbyte commented Jul 24, 2024

Thanks for your report.

I suspect this is intentional behaviour. Removing the sender name will just display the email address to recipients.

@murilopereirame
Copy link
Contributor Author

Thanks for your report.

I suspect this is intentional behaviour. Removing the sender name will just display the email address to recipients.

Then the Dialog shouldn't allow saving or it should throw an error. My main concern is that it returns success for an operation that will not be applied

@charlag charlag changed the title Removig Sender Name doesn't work Removing Sender Name doesn't work Oct 2, 2024
@hrb-hub hrb-hub self-assigned this Oct 14, 2024
hrb-hub added a commit that referenced this issue Oct 15, 2024
Alleviates user confusion when trying to edit alias.name after setting
it to empty string.
Reverts #4783

Fix #7254
hrb-hub added a commit that referenced this issue Oct 16, 2024
Alleviates user confusion when trying to edit alias.name after setting
it to empty string.
Reverts #4783

Fix #7254
@wrdhub wrdhub added this to the Next mail release milestone Oct 17, 2024
@wrdhub wrdhub closed this as completed Oct 18, 2024
wrdhub pushed a commit that referenced this issue Oct 18, 2024
Alleviates user confusion when trying to edit alias.name after setting
it to empty string.
Reverts #4783

Fix #7254
@BijinDev BijinDev self-assigned this Oct 21, 2024
@BijinDev BijinDev added the state:tested We tested it and are about to release it label Oct 21, 2024
jgoedde pushed a commit that referenced this issue Oct 28, 2024
Alleviates user confusion when trying to edit alias.name after setting
it to empty string.
Reverts #4783

Fix #7254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants