Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label selection dropdown #7757

Closed
5 tasks done
Tracked by #318
charlag opened this issue Oct 17, 2024 · 1 comment
Closed
5 tasks done
Tracked by #318

Label selection dropdown #7757

charlag opened this issue Oct 17, 2024 · 1 comment
Assignees
@hrb-hub
Labels
feature: labels goal: email for business no-release-notes (excluded from release notes) state:tested We tested it and are about to release it
Milestone
252.11.22 (Label ...

Comments

@charlag
Copy link
Contributor

charlag commented Oct 17, 2024 •
edited by hrb-hub
Loading

part of #318
estimated: 20h

AC

  • Lists all labels
  • Unassigned labels have an outlined label icon, assigned ones have a filled one
  • Label icon is colored like the label
  • It has a confirmation button to apply labels
  • Items have checkbox semantics for screen readers, selection status is reflected in accessibility tree

Test notes:

see #7756
@charlag charlag mentioned this issue Oct 17, 2024
Closed
30 tasks
@wrdhub wrdhub added this to the Labels milestone Nov 5, 2024
@charlag charlag modified the milestones: Labels, Next client release Nov 21, 2024
@charlag charlag closed this as completed Nov 21, 2024
@charlag charlag added the no-release-notes (excluded from release notes) label Nov 22, 2024
@hrb-hub hrb-hub self-assigned this Nov 22, 2024
@hrb-hub
Copy link
Contributor

hrb-hub commented Nov 22, 2024

Label's selection status (checked or not) is not available on screen readers

@hrb-hub hrb-hub added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label Nov 22, 2024
@hrb-hub hrb-hub mentioned this issue Nov 22, 2024
Closed
charlag added a commit that referenced this issue Nov 22, 2024
@charlag @hrb-hub
Fix label checkboxes not being recognized by screen readers
2693455 
#7757

Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>
charlag added a commit that referenced this issue Nov 22, 2024
@charlag @hrb-hub
Fix label checkboxes not being recognized by screen readers
2723002 
#7757

Close #8008

Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>
@charlag charlag mentioned this issue Nov 22, 2024
Merged
@hrb-hub hrb-hub self-assigned this Nov 25, 2024
@hrb-hub hrb-hub added state:tested We tested it and are about to release it and removed state:tested-with-comments Issue has been tested but some issues were found and needs review. labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrb-hub hrb-hub

Labels
feature: labels goal: email for business no-release-notes (excluded from release notes) state:tested We tested it and are about to release it
Projects
None yet
Milestone
252.11.22 (Label support)
Development

No branches or pull requests
3 participants
@charlag @wrdhub @hrb-hub