Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ListModel to separate Entity concerns from List concerns #8222

Closed
3 tasks done
charlag opened this issue Jan 7, 2025 · 0 comments · Fixed by #8212
Closed
3 tasks done

Refactor ListModel to separate Entity concerns from List concerns #8222

charlag opened this issue Jan 7, 2025 · 0 comments · Fixed by #8212
Assignees
@charlag
Labels
feature: conversation view goal: email for business state:tested We tested it and are about to release it
Milestone
259.250113.0

Comments

@charlag
Copy link
Contributor

charlag commented Jan 7, 2025 •
edited
Loading

Time taken: 9h

AC

  • ListModel does not require its item type to be ListElement
  • entityEventsReceived is not in ListModel

Test notes

  • View mails, move mails, select mails, go to different folders
@charlag charlag mentioned this issue Dec 13, 2024
Open
4 tasks
@paw-hub paw-hub linked a pull request Jan 7, 2025 that will close this issue
Refactor element-specific behavior out of ListModel #8212
Merged
@charlag charlag mentioned this issue Jan 10, 2025
Open
paw-hub added a commit that referenced this issue Jan 10, 2025
@paw-hub @hrb-hub
Refactor element-specific behavior out of ListModel
ce112b7 
We do not want ListModel to specifically only work on ListElement types,
or even element types in general. As such, we generalize it to a list of
some kind of elements with some kind of ID, even if these are not types
that would be stored remotely as part of the model.

Also renames entity/element to item for the ListModel.

Closes #8222

Co-authored-by: hrb-hub <181954414+hrb-hub@users.noreply.github.com>
@charlag charlag self-assigned this Jan 13, 2025
@charlag charlag added the state:tested We tested it and are about to release it label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
feature: conversation view goal: email for business state:tested We tested it and are about to release it
Projects
None yet
Milestone
259.250113.0
Development

Successfully merging a pull request may close this issue.

Refactor element-specific behavior out of ListModel tutao/tutanota
3 participants
@charlag @paw-hub @hrb-hub