Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MailListModel #8340

Closed
2 tasks done
paw-hub opened this issue Jan 21, 2025 · 0 comments · Fixed by #8343
Closed
2 tasks done

Add tests for MailListModel #8340

paw-hub opened this issue Jan 21, 2025 · 0 comments · Fixed by #8343
Labels
feature: conversation view maintenance dependency updates, key renewals, code cleanup state:tested We tested it and are about to release it
Milestone

Comments

@paw-hub
Copy link
Contributor

paw-hub commented Jan 21, 2025

AC

  • MailListModel has unit tests

Estimated time: 4h
Time taken: 7h

Test notes

  • All MailListModel tests pass

This change will be released alongside MailListModel, so refer to #8247 to actually test MailListModel.

@paw-hub paw-hub added maintenance dependency updates, key renewals, code cleanup feature: conversation view labels Jan 21, 2025
paw-hub added a commit that referenced this issue Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
@paw-hub paw-hub linked a pull request Jan 21, 2025 that will close this issue
paw-hub added a commit that referenced this issue Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 22, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 22, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
paw-hub added a commit that referenced this issue Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
hrb-hub pushed a commit that referenced this issue Jan 24, 2025
These were missing from MailViewModel, so they weren't required when the
code was refactored into MailListModel. However, we still want this code
tested as it has a lot of complex logic, especially regarding entity
updates.

Also fixes a few bugs with MailListModel that were found, particularly
with loadAndSelect. We can also remove one usage of loadAndSelect as
we can synchronously select an element, too, without any loading.

Closes #8340

Co-authored-by: bir <bir@tutao.de>
@hrb-hub hrb-hub added this to the Mailbox export milestone Jan 24, 2025
@charlag charlag added the state:tested We tested it and are about to release it label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: conversation view maintenance dependency updates, key renewals, code cleanup state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants