-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for MailListModel #8340
Labels
feature: conversation view
maintenance
dependency updates, key renewals, code cleanup
state:tested
We tested it and are about to release it
Milestone
Comments
paw-hub
added a commit
that referenced
this issue
Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 21, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 22, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 22, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
paw-hub
added a commit
that referenced
this issue
Jan 23, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
hrb-hub
pushed a commit
that referenced
this issue
Jan 24, 2025
These were missing from MailViewModel, so they weren't required when the code was refactored into MailListModel. However, we still want this code tested as it has a lot of complex logic, especially regarding entity updates. Also fixes a few bugs with MailListModel that were found, particularly with loadAndSelect. We can also remove one usage of loadAndSelect as we can synchronously select an element, too, without any loading. Closes #8340 Co-authored-by: bir <bir@tutao.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: conversation view
maintenance
dependency updates, key renewals, code cleanup
state:tested
We tested it and are about to release it
AC
Estimated time: 4h
Time taken: 7h
Test notes
This change will be released alongside MailListModel, so refer to #8247 to actually test MailListModel.
The text was updated successfully, but these errors were encountered: