Fix: Android notification not working #3796

[InfinityLoop1308]

Fix: Android notification not working #3796
Fix: remove useless dependency full-icu, which caused problem executing npm ci (See this issue)

Note: I don't really know if this fix of #3796 is the supposed way, but it works.

[InfinityLoop1308]

Another thing need to be mentioned: keytar needs libsecret so maybe a step of installing libsecret should be added to build instruction.

[charlag]

full-ice is a devDependency needed for tests, we will not remove it.
We will add a note about libsecret or at least make postinstall script not fail if it's not there.

I don't understand the fix yet (and it doesn't seem like you do either), there's already reschedule done in handleException() if it's appropriate. Did you find if you run into some branch that's failing? Can we reproduce it somehow?

[InfinityLoop1308]

full-ice is a devDependency needed for tests, we will not remove it. We will add a note about libsecret or at least make postinstall script not fail if it's not there.

see the link I quoted - it is a built-in module for node 16 above so there is no need to include it(and it made me fail doing npm ci)
Nodejs change log

I don't understand the fix yet (and it doesn't seem like you do either), there's already reschedule done in handleException() if it's appropriate. Did you find if you run into some branch that's failing? Can we reproduce it somehow?

The problem is, there is not any exception. I have no idea why this happened.

[charlag]

Oh, sorry, I overlooked the link about icu. We will remove it but let's do it separately from Android issue.

I think we should try to find out what happens in your case first. If there's no exception then it was a "happy" path

[InfinityLoop1308]

I think we should try to find out what happens in your case first. If there's no exception then it was a "happy" path

Sorry but I don't really know what is a "happy" path. Could you give more information?

[charlag]

@InfinityLoop1309 I meant that if no error has happened then it's probably working as intended - connects, waits for one response and then hangs until system says it's time to sleep again.
We need to understand the problem in order to fix it.

[InfinityLoop1308]

@InfinityLoop1309 I meant that if no error has happened then it's probably working as intended - connects, waits for one response and then hangs until system says it's time to sleep again. We need to understand the problem in order to fix it.

@charlag Seems the only reason it ran into finally without an exception is that reader.readLine() returns null. But why this occured remains a question.