Update Android SDK target to 14 #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wec43
force-pushed
the
android-sdk-target-14
branch
3 times, most recently
from
993bf86
to
99b72cb
Compare
charlag
reviewed
Jul 19, 2024
app-android/app/build.gradle
Outdated
| def room_version = '2.6.1' | ||
| def lifecycle_version = '2.8.3' | ||
| def activity_version = '1.9.0' | ||
| def coroutines_version = '1.8.1' | ||
|
|
||
| implementation "de.tutao:tutasdk" | ||
|
|
||
| // Important: cannot be updated without additional measures as Android 6 and 7 do not have Java 9 |
There was a problem hiding this comment.
should delete this comment now
| def lifecycle_version = "2.4.1" | ||
| def activity_version = "1.4.0" | ||
| def coroutines_version = "1.8.0" | ||
| def room_version = '2.6.1' |
There was a problem hiding this comment.
The option to enable Kotlin code generation (or “Kotlin CodeGen”) is now available in Room KSP. (4297ec0). To turn on Kotlin CodeGen in Room, add the room.generateKotlin option name to your processor options for KSP. For more details on how to pass processor options for KSP, see the KSP documentation.
There was a problem hiding this comment.
I added an option to let KSP generate Kotlin in gradle.
app-android/app/build.gradle
Outdated
|
|
||
| implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.4.1' | ||
| implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.8.3' | ||
| implementation "androidx.lifecycle:lifecycle-livedata-ktx:$lifecycle_version" |
There was a problem hiding this comment.
we can throw away livedata! maybe!!
wec43
force-pushed
the
android-sdk-target-14
branch
from
99b72cb
to
bb33170
Compare
charlag
approved these changes
Jul 19, 2024
wec43
force-pushed
the
android-sdk-target-14
branch
from
bb33170
to
f98037e
Compare
Update AGP, Kotlin and all dependencies versions Workaround AGP bug with rust plugin Adapt to KSP argument Remove unnecessary Android SDK version checks
Fix lifecycle related calls
wec43
force-pushed
the
android-sdk-target-14
branch
from
f98037e
to
bcba38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close https://github.com/tutao/private-issues/issues/207