Skip to content

Conversation

@nicholaschiang
Copy link
Member

@nicholaschiang nicholaschiang commented Oct 27, 2021

Fixes TB-148 as I'll probably use Postmark's built-in unsubscribe feature (instead of SendGrid's).

@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tutorbook/tutorbook/HToH8MpRYaDmTVHdmCpHGTwg5iGh
✅ Preview: https://tutorbook-git-postmark-tutorbook.vercel.app

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #265 (3bc6308) into develop (203fa95) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #265      +/-   ##
===========================================
- Coverage    70.26%   70.19%   -0.07%     
===========================================
  Files          223      223              
  Lines         4691     4691              
  Branches      1262     1262              
===========================================
- Hits          3296     3293       -3     
- Misses        1395     1398       +3     
Impacted Files Coverage Δ
lib/mail/components.tsx 9.67% <ø> (ø)
lib/mail/login.tsx 100.00% <ø> (ø)
lib/mail/meetings/create.tsx 100.00% <ø> (ø)
lib/mail/send.ts 22.22% <0.00%> (ø)
lib/mail/users/create.tsx 90.00% <ø> (ø)
lib/api/verify/members-unchanged.ts 50.00% <0.00%> (-50.00%) ⬇️
lib/api/routes/meetings/list.ts 66.66% <0.00%> (-25.00%) ⬇️
components/settings/general.tsx 55.17% <0.00%> (-10.35%) ⬇️
components/settings/index.tsx 95.23% <0.00%> (-4.77%) ⬇️
lib/model/meeting.ts 77.27% <0.00%> (-3.04%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203fa95...3bc6308. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 27, 2021



Test summary

29 5 0 0Flakiness 3


Run details

Project tutorbook
Status Failed
Commit 3bc6308
Started Nov 1, 2021 5:32 AM
Ended Nov 1, 2021 5:52 AM
Duration 19:41 💡
OS Linux Ubuntu - 20.04
Browser Chrome 94

View run in Cypress Dashboard ➡️


Failures

org/users/id/index.spec.ts Failed
1 User display page > collects profiles before booking meetings
org/signup.spec.ts Failed
1 Signup page > signs new volunteers up
profile.spec.ts Failed
1 Profile page > updates volunteer profiles
org/users/index.spec.ts Failed
1 Users page > copies org links and filters users
org/settings/index.spec.ts Failed
1 Org settings page > displays and updates org settings

Flakiness

org/search.spec.ts Flakiness
1 Search page > filters users by subjects, langs, and name
org/users/index.spec.ts Flakiness
1 Users page > falls back to invisible textarea copy-paste
overview.spec.ts Flakiness
1 Overview page > shows placeholders and accounts when logged in

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@linear
Copy link

linear bot commented Nov 1, 2021

TB-148 Add unsubscribe links to email footer

Use SendGrid's unsubscribe groups to add "Unsubscribe" links to the bottom of each notification email.

@nicholaschiang nicholaschiang marked this pull request as ready for review November 1, 2021 05:27
@nicholaschiang nicholaschiang merged commit 4fc88c0 into develop Nov 1, 2021
@nicholaschiang nicholaschiang deleted the postmark branch November 1, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants