[docker] Split dependencies from tuttleofx build #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis Warning: no python3-{clint&argcomplete} for trusty 14.04
Is is easier to maintain
- cmake build type release - make install/strip - Gain 100MB on docker image
* Because of a DockerHub limitation: cannot separately specify the build context and the dockerfile in Automated Builds. * See the following github issue: https://github.com/docker/hub- feedback/issues/292
| @@ -0,0 +1,10 @@ | |||
| FROM tuttleofx/tuttleofx-env:python3-latest | |||
There was a problem hiding this comment.
Including the python minor version is maybe clearer because it depends on the OS distrib image. Don't you think ?
There was a problem hiding this comment.
We only provide multiple images for the major versions, so it's easier to maintain like that.
added 5 commits
May 30, 2016 10:48
When install dependencies.
When install external dependencies.
* Revert of commit 2ea2261 * Because these packages are disallowing packages thanks to Travis apt- package-whitelist process...
Syntax error near unexpected token `elif'.
|
Error when launch c++ tests: |
| # easy_install3 pip --prefix=$HOME/local | ||
| # pip3 install --user clint argcomplete | ||
| # Use CONTINUOUS_INTEGRATION environment variable to detect if the script is run on Travis CI. | ||
| if [ -z ${CONTINUOUS_INTEGRATION} ]; then |
There was a problem hiding this comment.
Should be:
if [ -n "${CONTINUOUS_INTEGRATION}" ]; then
for packages missing from https://github.com/travis-ci/apt-package- whitelist
Conflicts: tools/travis/install_dependencies.sh
cchampet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.