Use oiiowriter plugin to writer DPX files #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2016 17:53
* This metadata is ignored by most of the format. * It is taken by the DPX for example.
* This metadata is ignored by most of the format. * It is taken by the DPX for example.
* This feature exists in the dpxwriter. * I add this parameter in the oiiowriter to delete the dpxwriter plugin when all of its features will be available in oiio plugins.
* The orientation is an 'int' and starts with 1 (default). * Fixed order of 90clockwise (rotated top right) and transverse (rotated bottom left).
…ndianness Use enum value instead of hardcoded int.
And set the hint of the 'endianness' parameter.
* This feature exists in the dpxwriter. * I add this parameter in the oiiowriter to delete the dpxwriter plugin when all of its features will be available in oiio plugins.
* Since oiio-1.4+, the library made a lot of improvements to write DPX images. * For these reasons, the dpx writer is not needed anymore.
…indicated Avoid having metadata in the output file with empty value.
This parameter could be used in other format than JPEG (PNG for example).
cchampet
changed the title
|
I think you could also remove the PNG reader/writer plugins. These plugins have almost the same performance to decode/encode png images (5~10% better than oiio), but the oiio writer plugin has a lot of features the png writer doesn't have (subsampling, metadata...). @fabiencastan What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If needed, there is an oiio property: dpx:Transfer.
If needed, there is an oiio property: dpx:Colorimetric.
If needed, there is an oiio property: dpx:Packing.