sam ls: fixed --script option when displaying recursive items #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2016 10:56
No need to compare 'args.level' to 0: if it is the case, 'level' should be equal to 0 too.
added 4 commits
August 18, 2016 11:25
* If no user input, will browse in the current working directory. * Us '.' as current folder instead of the absoulte path to the working directory.
…an abs * Use os.path.isabs * Reorder the if statement.
We use os.path.join method after this code to concatenate the filepath and the filename.
| @@ -184,16 +183,16 @@ def _printItem(self, item, args, level): | |||
| filePath = colored.red(os.path.join(filePath, filename)) | |||
| filePath += ' \t' | |||
There was a problem hiding this comment.
should move into the toPrint
added 2 commits
August 19, 2016 12:18
* No need to do all this stuff. * getFolder() contains the path as given by the user. So if it's absolute, it will stay absolute and if it's relative it will stay relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #571