Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra type cast to String before call split() #76

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Add extra type cast to String before call split() #76

wants to merge 1 commit into from

Conversation

MinhThienDX
Copy link

Fix bug when call split() on number
Similar to this PR #74 but he changed the minified version

Fix bug when call split() on number
@pduey
Copy link

pduey commented Sep 18, 2019

Instead of calling data("chained") and casting to String, per the jquery docs, we could call attr("data-chained") instead, and instead of coercing strings into numbers, the String type will be preserved.

I've done that on my own branch and it works.

// var data = $(this).data("chained");
var data = $(this).attr("data-chained");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants