Skip to content

Commit

Permalink
gracefully acknowledge existing affiliate tags
Browse files Browse the repository at this point in the history
  • Loading branch information
Iulius Gutberlet committed Feb 28, 2013
1 parent e41b156 commit 9f278e9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion background.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ var configurations = {
for ( var config in configurations) {
if( configurations.hasOwnProperty(config) ) {
if (tUrl.match(configuration[config].rx) ) {
if (tUrl.indexOf("tag=") == -1 ) {
//gracefully acknowledge existing affiliate tags
if (tUrl.indexOf(config.params[0].param) == -1 ) {
r = { redirectUrl: tUrl+(tUrl.indexOf("?") == -1 ? "?" : "&")+createTag(config.params) };
// A supported site was found
// get the current window
Expand Down

1 comment on commit 9f278e9

@rikai
Copy link

@rikai rikai commented on 9f278e9 Mar 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, this is the main bit of the commit i have issue with. If someone has installed the JB extension it's assumed they want the JB affiliate tags applied at all relevant sites without having to check to verify at each site that the tag is being applied.

Having to do that defeats half the point of the extension. What i would prefer to here is to add an icon to the bar for JB, and allow people to disable the extension functionality to allow people to use other affiliate codes if they need to. This would be similar to how Adblock Plus allows you to enable/disable functionality on a temporary basis if you've used that before?

I have opened JupiterBroadcasting#10 to track this for chrome to match JupiterBroadcasting/JBAR-Firefox#1 which i'd already opened.

Please sign in to comment.