Fix bugs and limitations in NTFS utilities encountered with deep paths (over 20 levels) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (over 20 levels) This affects ntfscluster and ntfsmove. * Don't output the path if utils_inode_get_name() returns an error, which previously would output an uninitialized string for deep paths, producing random garbage. * If the path depth limit is encountered, utils_inode_get_name() now returns a partial path beginning with ".../" instead of an error code. * Increase utils_inode_get_name()'s path depth limit from 20 to 40. * Always free temporary memory, previously lost for deep paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects ntfscluster and ntfsmove.
Don't output the path if utils_inode_get_name() returns an error, which
previously would output an uninitialized string for deep paths, producing
random garbage.
If the path depth limit is encountered, utils_inode_get_name() now returns
a partial path beginning with ".../" instead of an error code.
Increase utils_inode_get_name()'s path depth limit from 20 to 40.
Always free temporary memory, previously lost for deep paths.
Arguably, there shouldn't be a small fixed depth limit, but another means of loop detection, but I'm not inclined to fix and test this properly.