fix(deps)!: update winit to 0.29 #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tversteeg
force-pushed
the
winit-update
branch
from
7f2213f
to
8cc864a
Compare
tversteeg
changed the title
|
There's a lot of extraneous formatting changes in this PR that would better be included in a separate PR. Regardless, this would be great to get merged as I'd like to use |
mkrasnitski
reviewed
Jan 30, 2024
5 tasks
tuzz
added a commit
that referenced
this pull request
Feb 15, 2024
I decided not to apply the cargo fmt for now to keep the change clearer in the commit history. Thanks @tversteeg for guiding me through the update with your pull request: #21
|
Thanks @tversteeg, this change is now applied in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My editor also applied
cargo fmt.It's a breaking change because a winit error is returned and because the winit versions are not compatible.