Add support for prepared statements with positional arguments #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prepared statement implementation on the C bindings are "non-connection". The binding build script needs to be updated to include this commit which adds the DB connection as a dependency for proper preparation. This is in-scope for this PR and will be done next. |
tvandinther
force-pushed
the
15-add-support-for-prepared-statements-with-positional-arguments
branch
from
39aadf3 to
e68f8fa
Compare
If there are no returned rows, we can not parse it to find the column types. This check fixes a bug where the process would crash if there were no rows as it was using a null pointer to ask for column types.
tvandinther
deleted the
15-add-support-for-prepared-statements-with-positional-arguments
branch
tvandinther
added a commit
that referenced
this pull request
Jul 7, 2024
* Add positional argument tests * Implement passing implementation of positional arguments for #15 * Change order of methods * Refactor prepared statement into new class * WIP * remove prints * add items to gitignore * Add null check to row column type population If there are no returned rows, we can not parse it to find the column types. This check fixes a bug where the process would crash if there were no rows as it was using a null pointer to ask for column types. * make os for build runners consistent with test runners * Add documentation for positional arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15