solidus-4.3 #1
Open
solidus-4.3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While installing it locally it should be the default as it is the latest version.
We use at least Alchemy 7.0
1. Run the config in after initialize, so we make sure the menu has been setup by the main app correctly 2. We use the new remix icons if the new admin menu is used. 3. We add our menu tab above the settings icon.
Fixes for Solidus 4.2 menu items
We need to load rspec first in order to get automatic screenshots
The link dialog in Alchemy 7.1 has changed. It now uses Shoelace Tabs made out of Custom Web Components. This keeps existing overrides. Note: That will cause a note in Rails log about not matching overrides. Those can safely be ignored.
Alchemy 7.1 now allows to submit the form like any other form with Enter key and prevents submits correctly. This still works with Alchemy 6.1 and 7.0 because of the data attribute we kept on the button tag.
Test with Solidus 4.2 as well
We do not need node anymore
Add deface overrides for Alchemy 7.1
Drop Solidus 3 support
tvdeyen
force-pushed
the
update-ci-matrix
branch
from
d371d9e to
93fa687
Compare
We only support Solidus 4.x now and can finally remove this complicated setup code.
tvdeyen
force-pushed
the
update-ci-matrix
branch
from
93fa687 to
8f8c716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.