Skip to content

Commit

Permalink
Add a pagination override to fix Bootstrap z-index issue
Browse files Browse the repository at this point in the history
Bootstrap adds a `z-index: 2` to active pagination items.
Why they did this is not very clear. I would consider this a bug,
because no other pagination element has any `z-index` set and I do not
see any visual difference here. Leaving the `z-index` wis problematic
if we implement a sticky header for instance.
  • Loading branch information
tvdeyen committed Oct 5, 2017
1 parent 31ef7f4 commit 8c8a483
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.pagination .page-item.active .page-link {
// overwrite a weird `z-index: 2` from Bootstrap,
// so it does not peak out of the sticky header
z-index: auto;
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
@import 'spree/backend/components/list_group';
@import 'spree/backend/components/messages';
@import 'spree/backend/components/progress';
@import 'spree/backend/components/pagination';
@import 'spree/backend/components/table-filter';
@import 'spree/backend/components/navigation';
@import 'spree/backend/components/sidebar';
Expand Down

0 comments on commit 8c8a483

Please sign in to comment.