Use base64 -d on all Linux platforms and --decode on others #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The busybox (Alpine) version of the base64 command does not support the long form flag '--decode' and the macOS version does not support '-d' so we have to use different base64 commands depending on the platform.
|
I never saw this - Thanks for taking the time to do this, I haven't had an any time to try it out recently. This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
to hopefully get Invicton-Labs#3 moving,
I have transplanted the fix used in traefik/traefik#2344 to your branch.
traefik is MIT licensed and I have credited and linked their PR for this small piece of code so should be totally OK.
They are still using this exact fix today, 5 years later, so it appears to work well for them:
https://github.com/nknapp/traefik/blame/master/contrib/scripts/dumpcerts.sh#L45
I want to push to your fork of the terraform-external-shell-resource repository so when Invicton-Labs#3 gets merged your contribution is credited. If I made my own PR it would be duplicated first of all, but also your contribution would be lost.
Thanks!