-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Docker image, docker compose for project #54
Comments
I'm all for it! Would hitting #29 be a natural fit at the same time? |
Looks like it. Docker Compose has ways to use environment variables and should pull from an |
This adds a Dockerfile and .dockerignore file to allow the project to built as a docker image. First of several incremental changes for Docker friendliness. tvkitchen#54 Make Docker image, docker compose for core project
This issue was created before we moved to the library architecture; now that we have that, the concept of docker containers are more relevant to the recipes and appliances directly. We may still find that the countertop should have its own docker container, but for now I think we can close this? (Please feel free to re-open if I'm totally wrong!) |
Feature Request
Describe the solution you'd like
It'd be good if this project had an official Docker image and Docker Compose file for running the project. Dockerization may be a good approach for TV Kitchen, because people will want to run this in varied environments and Docker allows them to do that without additional setup or modification to those environments, making the project easier to run and manage. In the future, these may include Kubernetes or the various AWS services that support containers.
My suggested plan of action would be:
docker-compose up -d kafka
Can do a quick PR with this if we think this is a good plan.
The text was updated successfully, but these errors were encountered: