Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker image, docker compose for project #54

Closed
6 tasks
chriszs opened this issue Jun 6, 2020 · 3 comments
Closed
6 tasks

Make Docker image, docker compose for project #54

chriszs opened this issue Jun 6, 2020 · 3 comments
Labels
devops help us make is possible to make things enhancement New feature or request

Comments

@chriszs
Copy link
Contributor

chriszs commented Jun 6, 2020

Feature Request

Describe the solution you'd like

It'd be good if this project had an official Docker image and Docker Compose file for running the project. Dockerization may be a good approach for TV Kitchen, because people will want to run this in varied environments and Docker allows them to do that without additional setup or modification to those environments, making the project easier to run and manage. In the future, these may include Kubernetes or the various AWS services that support containers.

My suggested plan of action would be:

  • Add a Dockerfile
  • Add a Docker build step in Travis
  • Move docker-compose file to project's top level (this is convention), add TV kitchen image to it
  • Switch Kafka start command to do docker-compose up -d kafka
  • Document Docker compose option in README
  • Use Travis to push an official image to a TV Kitchen Docker Hub project on commits, version releases

Can do a quick PR with this if we think this is a good plan.

@chriszs chriszs added the discussion The conversation is the point label Jun 6, 2020
@chriszs chriszs changed the title Think through Docker strategy Make Docker image, docker compose for core project Jun 6, 2020
@chriszs chriszs added devops help us make is possible to make things enhancement New feature or request and removed discussion The conversation is the point labels Jun 7, 2020
@reefdog
Copy link
Contributor

reefdog commented Jun 8, 2020

I'm all for it! Would hitting #29 be a natural fit at the same time?

@chriszs
Copy link
Contributor Author

chriszs commented Jun 10, 2020

Looks like it. Docker Compose has ways to use environment variables and should pull from an .env file in the working directory.

chriszs added a commit to chriszs/tv-kitchen that referenced this issue Jun 13, 2020
This adds a Dockerfile and .dockerignore file to
allow the project to built as a docker image. First of
several incremental changes for Docker friendliness.

tvkitchen#54 Make Docker image, docker compose for core project
@chriszs chriszs mentioned this issue Jun 13, 2020
1 task
@chriszs chriszs changed the title Make Docker image, docker compose for core project Make Docker image, docker compose for project Sep 27, 2020
@slifty
Copy link
Member

slifty commented Sep 27, 2020

This issue was created before we moved to the library architecture; now that we have that, the concept of docker containers are more relevant to the recipes and appliances directly.

We may still find that the countertop should have its own docker container, but for now I think we can close this? (Please feel free to re-open if I'm totally wrong!)

@slifty slifty closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops help us make is possible to make things enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants