Clean typeguard syntax #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first typeguard in the repository and the syntax I used was a bit more verbose than necessary. By casting once we save a whole bunch of redundancy and the guard becomes easier to understand
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 48 49 +1
Branches 16 16
=========================================
+ Hits 48 49 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
(Not sure this is better yet -- gonna sleep on it) |
|
Some thoughts related to this.
I'm likely going to close this issue without merging, and instead opt for a validation library (and then validate more inputs in more places even if they're typed) |
|
Closing this since #167 makes it obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a somewhat cleaner type guard syntax.
Functionality should basically be the same.