Drop Compass support, bump minimum Sass version #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compass is no longer maintained and hasn't seen a release for 3 years. The compass gem locks Sass to version < 3.5. However, we now need Sass v3.5+ due to sass/sass#2383 This commit removes compass support and bumps minimum Ruby Sass version to v3.5.2.
gmacdougall
pushed a commit
to gmacdougall/solidus
that referenced
this pull request
May 14, 2018
Bootstrap 4.x requires at least sass 3.5.2. For more information see: twbs/bootstrap-rubygem#122 sass/sass#2383
jhawthorn
pushed a commit
to solidusio/solidus
that referenced
this pull request
May 15, 2018
Bootstrap 4.x requires at least sass 3.5.2. For more information see: twbs/bootstrap-rubygem#122 sass/sass#2383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compass is no longer maintained and hasn't seen a release for 3 years.
The compass gem locks Sass to version < 3.5.
However, we now need Sass v3.5+ due to
sass/sass#2383
This commit removes compass support and bumps minimum Ruby Sass version
to v3.5.2.