Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $grid-columns argument to grid mixins #663

Closed
silvenon opened this issue Jul 12, 2014 · 2 comments
Closed

Add $grid-columns argument to grid mixins #663

silvenon opened this issue Jul 12, 2014 · 2 comments

Comments

@silvenon
Copy link

And make it default to $grid-columns. For example:

// Generate the extra small columns
@mixin make-xs-column($columns, $gutter: $grid-gutter-width, $grid-columns: $grid-columns) {
  position: relative;
  float: left;
  width: percentage(($columns / $grid-columns));
  min-height: 1px;
  padding-left:  ($gutter / 2);
  padding-right: ($gutter / 2);
}

Don't know how Sass reacts the argument being named the same as global, though.

I would love to see this feature, though I'm not sure if I'm overseeing something obvious.

@cvrebert
Copy link
Collaborator

A similar change is planned upstream for Bootstrap v4: twbs/bootstrap#13965
As the Sass version is a translation of the upstream Less code, it also won't be changed here until v4.

@silvenon
Copy link
Author

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants