Let grid mixins to pass columns total as parameter #13965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arbitrary simultaneous grids and uneven columns - Add the total amount of columns in a grid to grid mixins as a parameter - Use global variable @grid-columns as default value for backward compatibility
|
I'd rather just knock this off in v4 to be honest. The addition of the third parameter makes for a slightly awkward implementation with the columns, gutter, total columns ordering. Also, our grid mixins duplicate a lot of code and we need to split them apart a bit more I believe. |
|
Thinking more about it, yeah, let's punt to v4. |
|
Okay. Is v4 already in development? |
|
Nope, but hopefully soon. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary simultaneous grids and uneven columns
Closes #13959