Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Nuget packager for v3.1.1 #583

Closed
wants to merge 7 commits into from
Closed

Conversation

jamesmosier
Copy link

I created a nuget folder which contains the proper files for use with NuGet (ASP.NET package manager). It will pull the exact files from the appropriate folders within the master branch. Only oddity is the version number in the Package.nuspec file. I am waiting on a response from the NuGet team, but I accidentally published a package with version 3.1.1 and unfortunately they don't allow you to overwrite a version. So instead I had to make it 3.1.02, which is of course not ideal.

@nschonni
Copy link
Contributor

👍 on the nuspec, but 👎 on including the binary
I was looking at http://appveyor.com com for some Windows builds, and they offer NuGet publishing as part of the CI

@jamesmosier
Copy link
Author

So what are your thoughts on how to achieve this? I guess I was under the impression that NuGet pushing was a manual publish process, not an automated one. I need the binary to publish it correctly. Also, how is it possible to automate it without exposing the NuGet API key?

@nschonni
Copy link
Contributor

You can publish if you have the binary in your path. I don't think people on other platforms (like Bower) want to pull down the extra 1.6 megs for the NuGet binary.

@jamesmosier
Copy link
Author

I see, that makes sense. I removed it and will just manually re-add it in whenever I need to build future version(s). Does that solve the issue?

@nschonni
Copy link
Contributor

Protip: If you don't squash down the commits, the EXE is still going to end up bloating the git history

@jamesmosier
Copy link
Author

squashed the past 3 of my commits...

@glebm
Copy link
Member

glebm commented Apr 14, 2014

This can only be built on Windows? It uses a different version format? I won't merge this as I cannot even test it

@jamesmosier
Copy link
Author

Correct. It is used with Visual Studio on Windows. And that's alright, I'll just use it personally instead...

@nschonni
Copy link
Contributor

@glebm I believe it can be run with Mono, but it is a .Net package manager so the main user base is on Windows.

@glebm
Copy link
Member

glebm commented Apr 14, 2014

@nschonni I am all for supporting another package manager, so if we can build this with Mono, this can be merged. However, as it is now, I don't think I can run it because no PowerShell even with Mono?

@nschonni
Copy link
Contributor

@Jamez14 if you update the <files> section to map to the existing repo location, then the powershell script shouldn't be needed (I think). Then it is just a matter or running nuget pack Package.nuspec to create the zip/package

@jamesmosier
Copy link
Author

Cleaned up the publish.ps1 to pull from existing repo location. Also I have it pull down binaries in publish file. Not sure if this solved the issue of being able to run on Mono or not. If it's still not up to par, I'll just make it the unofficial Nuget package for bootstrap-sass. I'm currently using it at work with our app successfully.

@glebm
Copy link
Member

glebm commented Apr 18, 2014

@Jamez14 I started reading about Mono, Nuget, Pash, and looks for now Windows is the way to build this. In light of this, a separate repo with a Nuget build script would be best. Perhaps then it can be made official too. /cc @twbs/team

@jamesmosier
Copy link
Author

Alright, should I create this separate repo or hold off for now?

@glebm
Copy link
Member

glebm commented Apr 18, 2014

@Jamez14 Go for it 👍

@glebm glebm closed this Apr 18, 2014
@cvrebert
Copy link
Collaborator

Perhaps Outercurve could do the packaging? They already manage the Less-based Bootstrap package: http://www.nuget.org/packages/bootstrap/

@glebm
Copy link
Member

glebm commented Apr 18, 2014

Didn't know about Outercurve, would be great.

@jamesmosier
Copy link
Author

Just as an FYI, I updated my NuGet package to v3.2.0 this morning. I'm not sure if we ever came to a conclusion on this, but either way, here's the source/package links: GitHub project & NuGet package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants