Skip to content

Commit

Permalink
bower.json: Remove bootstrap.css from main
Browse files Browse the repository at this point in the history 
Per bower/spec#43 :
> Use source files with module exports and imports over pre-built distribution files.

Also, the example in that PR doesn't include
/dist/movement.css or /dist/movement.min.css
in its `main`.

If you have a complaint about this, take it up with the Bower folks:
https://github.com/bower/bower.json-spec/issues
  • Loading branch information
@cvrebert
cvrebert committed Apr 24, 2015
1 parent 6cb9d6c commit 3886198
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"homepage": "http://getbootstrap.com",
"main": [
"less/bootstrap.less",
"dist/css/bootstrap.css",
"dist/js/bootstrap.js"
],
"ignore": [
Expand Down

9 comments on commit 3886198

@bitwit
Copy link

@bitwit bitwit commented on 3886198 Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I understand that this isn't a bootstrap issue directly, isn't it arguably grounds for a minor version bump rather than a patch? Totally broke our builds using ~3.3.4.

@darlanalves
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just lost a bunch of hair trying to figure out why my project suddenly stopped working.

I agree with @bitwit, at least a minor change should be made. Totally breaks every app from now on that uses automatic dependency injection into HTML files in the build process (like mine).

@stephenbaidu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This change freaked me out a bit.

@cvrebert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16663 for further discussion.

@goldenice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insane. A minor version bump is the least you could do. I spent an hour debugging why my project suddenly did not add the default bootstrap styles anymore.

@jbgomond
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ! I spent an hour trying to find out why my app was crashing ...

@renomateo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitwit yeah, this is rediculous

@mdo
Copy link
Member

@mdo mdo commented on 3886198 Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, in hindsight we should've communicated this better and bumped the minor version. Apologies for the ongoing hiccup folks <3.

@fcagalj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe isn't a bootstrap issue directly, but it was absolutely unnecessary. It should be obviously that will cause a lot of headache:

#16663

Please sign in to comment.