Skip to content

Commit

Permalink
Applied translate3d to modal, navbar-fixed and affix to combat browse…
Browse files Browse the repository at this point in the history
…r repaint
  • Loading branch information
ItsJonQ committed May 21, 2014
1 parent 3dd1531 commit 7da34cc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions less/modals.less
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@

// When fading in the modal, animate it to slide down
&.fade .modal-dialog {
.translate(0, -25%);
.translate3d(0, -25%, 0);
.transition-transform(~"0.3s ease-out");
}
&.in .modal-dialog { .translate(0, 0)}
&.in .modal-dialog { .translate3d(0, 0, 0) }
}

// Shell div to position the modal with bottom padding
Expand Down
1 change: 1 addition & 0 deletions less/navbar.less
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@
right: 0;
left: 0;
z-index: @zindex-navbar-fixed;
.translate3d(0, 0, 0);

This comment has been minimized.

Copy link
@jasny

jasny Jul 24, 2014

Contributor

The rule is causing a world of pain.

CSS3 transforms causes the object to act as a containing block for fixed positioned descendants. So you can no longer use fixed positioned items in a .navbar. This causes issues like jasny/bootstrap#278.

This comment has been minimized.

Copy link
@cvrebert

cvrebert Jul 24, 2014

Collaborator

@jasny Please file a new issue. Issues are preferred over past commit comments.


// Undo the rounded corners
@media (min-width: @grid-float-breakpoint) {
Expand Down
1 change: 1 addition & 0 deletions less/utilities.less
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@

.affix {
position: fixed;
.translate3d(0, 0, 0);
}

0 comments on commit 7da34cc

Please sign in to comment.