Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<figure> and normalize.css v3.0.0 #12424

Closed
krnlde opened this issue Jan 29, 2014 · 5 comments
Closed

<figure> and normalize.css v3.0.0 #12424

krnlde opened this issue Jan 29, 2014 · 5 comments
Labels
Milestone

Comments

@krnlde
Copy link
Contributor

krnlde commented Jan 29, 2014

I recognized that the <figure> now has margin: 1em 40px; since the latest normalize.css.

Resetting it to margin: 0; will solves the difference.

figure {
  margin: 0;
}
@cvrebert
Copy link
Collaborator

Solves what difference?

@krnlde
Copy link
Contributor Author

krnlde commented Jan 29, 2014

The difference between 1em 40px and 0.

@juthilo
Copy link
Collaborator

juthilo commented Jan 29, 2014

1em 40px seems to be the default across most browsers and conforms to the "Typical default display properties" from the W3C Working Draft.

X-Ref: necolas/normalize.css#262

@krnlde
Copy link
Contributor Author

krnlde commented Jan 29, 2014

You're right. But updating to this commit will still break some layouts when used untouched. I'm just addressing this issue.

Can we close this issue or is there work to be done by bootstrap?

@cvrebert
Copy link
Collaborator

/cc @mdo

@mdo mdo closed this as completed in 545c957 Jan 30, 2014
@mdo mdo mentioned this issue Jan 30, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
…nt so that we don't potentially screw folks over
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
…nt so that we don't potentially screw folks over
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants