Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.panel-body:after absent from customized bootstrap 3.1.1 #13305

Closed
1730wang opened this issue Apr 8, 2014 · 9 comments · Fixed by #13543
Closed

.panel-body:after absent from customized bootstrap 3.1.1 #13305

1730wang opened this issue Apr 8, 2014 · 9 comments · Fixed by #13543
Milestone

Comments

@1730wang
Copy link

1730wang commented Apr 8, 2014

Before fix:
image

After fix:
image

The fix is:

.panel-body:after {
content: " ";
display: table;
}

@1730wang 1730wang changed the title .panel-body:after was removed from bootstrap 3.1.1 and it is causing problem .panel-body:after was removed from bootstrap 3.1.1 and it is causing problem, Grid inside a Panel Apr 8, 2014
@mdo
Copy link
Member

mdo commented Apr 8, 2014

The CSS for that is still present, it's just been moved: https://github.com/twbs/bootstrap/blob/master/dist/css/bootstrap.css#L5837:L5838.

@mdo
Copy link
Member

mdo commented Apr 8, 2014

JS Bin?

@cvrebert cvrebert added the css label Apr 8, 2014
@1730wang
Copy link
Author

1730wang commented Apr 9, 2014

just tried in jsbin, seems not an issue if I use the whole css file //netdna.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css

on my local, i use customize downloaded css from http://getbootstrap.com/customize/
only included Grid system and Panels

image

@cvrebert cvrebert changed the title .panel-body:after was removed from bootstrap 3.1.1 and it is causing problem, Grid inside a Panel .panel-body:after absent from customized bootstrap 3.1.1 Apr 9, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Apr 9, 2014

Confirmed in bleeding-edge master branch Customizer too.

@cvrebert
Copy link
Collaborator

cvrebert commented Apr 9, 2014

Including utilities.less fixes the issue.

@cvrebert
Copy link
Collaborator

cvrebert commented Apr 9, 2014

X-Ref: #12409.

@cvrebert cvrebert added customizer and removed css labels Apr 20, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Apr 20, 2014
@cvrebert
Copy link
Collaborator

@mdo So, since :extend()-ing mixins still hasn't been implemented in Less, I think we need to move the .clearfix class out of utilities.less and make it mandatory; otherwise, the :extend()s break, hence this bug. Or else we need to make utilities.less mandatory. Thoughts?

@cvrebert
Copy link
Collaborator

cvrebert commented May 4, 2014

@mdo Ping.

@mdo mdo modified the milestones: v3.2.1, v3.2.0 May 8, 2014
@mdo
Copy link
Member

mdo commented May 8, 2014

For simplicity and versioning and compatibility, we should require the entire utilities.less file—just like we do with scaffolding and Normalize. Simplifies a lot of the pain here and elsewhere without adding much overhead at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants