Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaker contrast of links in inverted navbar #13943

Closed
andrzej-aa opened this issue Jun 26, 2014 · 3 comments
Closed

Weaker contrast of links in inverted navbar #13943

andrzej-aa opened this issue Jun 26, 2014 · 3 comments
Labels
css
Milestone
v3.3.0

Comments

@andrzej-aa
Copy link

In BS 3.2.0 default color of links in inverted navbar changed from #999 to #777. Now it has weaker contrast. Was it planned?
@cvrebert cvrebert added the css label Jun 26, 2014
@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 26, 2014

That's due to 8c403dc, the inverted navbar was probably overlooked. /cc @mdo

@cvrebert cvrebert added this to the v3.2.1 milestone Jun 26, 2014
@cvrebert cvrebert mentioned this issue Jul 6, 2014
Closed
@mdo mdo closed this as completed in 0378a6b Jul 6, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Aug 8, 2014

X-Ref: #13847.

@cvrebert cvrebert mentioned this issue Aug 8, 2014
Closed
@chrisbainbridge
Copy link

This patch only appears to lighten @navbar-inverse-color: lighten(@gray-light, 12%); - does it not also need to lighten the @navbar-inverse-link-color: @gray-light; ?

Also isn't the w3c minimum contrast ratio 4.5, whereas this patch sets the ratio to 96:22 which is 4.41 ie. still below the minimum? Hence why it was previously #99, as that is the lowest hex value to meet the minimum #99/#22 == 4.5.

@cvrebert cvrebert reopened this Aug 8, 2014
@mdo mdo closed this as completed in 9a39ee9 Aug 23, 2014
@ziemkowski ziemkowski mentioned this issue Sep 15, 2014
Closed
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#13943: Lighten the navbar inverse link color more s…
7b59bde 
…ince our text contrast change in v3.2.0
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#13943 again: lighten links, and text, in navbar. St…
eb225be 
…ill not 100% compliant, but it's better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
4 participants
@andrzej-aa @cvrebert @hnrch02 @chrisbainbridge