-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE backslash hack on .img-responsive stretches images in IE<11 #13996
Comments
It was added for SVG images, fixing #10073. |
Seems like it was applied too broadly, no? How are we supposed to handle responsive images in IE < 11 now? I've applied an override, but that just doesn't seem right. |
Yeah, probably need to revisit to test more things out. |
Perhaps we could qualify the |
Sorry if this is completely unrelated, but I noticed a bug in IE <=10 where img-thumbnail is also stretching the image to the size of the containing div. it was working fine in 3.1.1.. I'm now on 3.2.0. |
@cvrebert That seems awfully specific and won't handle all cases, like a source with a query string (which is pretty common) or a source without an extension. |
The image I was working with is a standard .jpg
|
Given that this breaks more than it really fixes, I think reverting the fix and adding a callout to the docs suggesting the fix of |
Why not |
Because if we only assign |
Is the JPG issue i'm facing related to this? If not, I'm happy to file a different issue. |
@amit777 Have an example or screenshot? |
Ended up doing what @hnrch02 suggested. Reverted the hack and documented the need for it for SVG images. |
@isherwood - try adding "width: auto" to .img-responsive in your local CSS file. That will override the BS stylesheet. |
@acrogenesis What do you mean by "this doesn't work"? |
@hnrch02r it isn't applied hence the strikethrough |
@acrogenesis It isn't supposed to be applied in Safari 8, it's a hack for IE 8-10. Also, it has been removed from the code base and won't be included in 3.2.1. |
…ck for SVG img-responsive
The fix for responsive SVG images in IE8 caused more problems than it solved. It has been removed from more modern versions of Bootstrap. Details: twbs/bootstrap#13996
A width statement on
.img-responsive
stretches images beyond their pixel dimensions in IE <= 10. It wasn't there before v3.2.0, and I can't seem to find any explanation or discussion of the issue..img-responsive, .thumbnail > img, .thumbnail a > img, .carousel-inner > .item > img, .carousel-inner > .item > a > img { width: 100% \9; }
See http://jsfiddle.net/isherwood/eLQqW.
The text was updated successfully, but these errors were encountered: