Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making .tooltip('show') throw an error when the target is display: none #14155

Closed
cvrebert opened this issue Jul 15, 2014 · 3 comments
Closed
Labels

Comments

@cvrebert
Copy link
Collaborator

This would allow us to drop a callout from the tooltip & popover docs and make the mistake more obvious to our users.

The current callout:

Don't try to show tooltips on hidden elements

Invoking $(...).tooltip('show') when the target element is display: none; will cause the tooltip to be incorrectly positioned.

@cvrebert cvrebert added this to the v4.0.0 milestone Jul 15, 2014
@cvrebert cvrebert added the js label Jul 15, 2014
@itamark
Copy link

itamark commented Jul 26, 2014

How can the target's tooltip activate if it's display:none? Do you mean if tooltip is triggered elsewhere in the JS?

@cvrebert
Copy link
Collaborator Author

@itamark $(...).tooltip('show') is what does the activation. Perhaps you're confusing $(...).tooltip(options) (i.e. the initializer) with $(...).tooltip('show')? See also e.g. #13322.

@mdo
Copy link
Member

mdo commented Aug 2, 2014

Punting to v4 checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants