-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gburton
referenced
this pull request
in gburton/CE-Phoenix
Sep 1, 2015
Remove Glyphicon in favour of FontAwesome
jesperronn
referenced
this pull request
Sep 12, 2016
The download link for Entypo (on its website) is invalid. It's a Dropbox link which now results in a 403 error. The website was last updated in 2015 (as seen in the footer).
* Base the outline button :active color on the background, fixing a contrast issue * Only apply focus outline to active when it's focused
This commit allows nested structures for accordions. Also a part of the documentation about data-children is removed because this functionality didn't work and it's not applicable anymore. Tests with the collapse accordion are also a bit adjusted to the new situation.
The append and prepend classes vertically aligned items in the center For textareas this meant the addon would aling vertically instead of stretch and have it's contents vertically aligned these changes fix that so everything is aligned how it should be
…trap into ysds-docs-border-utilities
This reduces duplication and the chances to forget to update something.
While the old one will keep working, better switch to the new one.
This reverts commit 7052085.
Uses orphans/widows trick from @fran-worley at #20925 (comment). Fixes #20925.
1. It's == "it is" 2. The subject of the sentence is "Only one" (not "these") so the verb must agree with it. Feel free to do nothing with this change, use it, etc - I just saw this while reading through the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 4
This is the primary pull request for developing and shipping Bootstrap 4. You should know a few things coming into this:
v4-dev
branch.Heads up! This thread has been locked to contributors. Please use issues for questions, comments, and feedback about particular changes. We'll cross reference them here as they come up.
Read the v4 alpha announcement blog post for more details on these changes and some of the open questions we still have to answer.
Big picture
We've got a number of big changes coming in v4. To name a few:
~480px
tier.@grid-float-breakpoint
usesWe also have some super ambitious nice to haves:
What about v3?
We will continue to support Bootstrap 3, but only for critical bug fixes and documentation updates. No new features will be added, and nothing will be removed. If you need IE8 support, Bootstrap 3 has your back (or you can go out of your way to re-implement it in v4).
Be aware that we will set a reasonable date in the future to completely discontinue v3 support.
Feature breakdown
Here's the breakdown by feature/component of the updates we've made to v4, as well as some that are still todo.
CSS
Global
rem
s as the main sizing unit.@border-radius: true
and get rounded corners).@*-small
to@*-sm
, etc. (Change all variables from @*-small and @*-large to @*-sm and @*-lg #10352)@import
-ed filenames with_
(e.g.,_dropdown.scss
)>
selectors and replace with un-nested classes..disabled
on nav links, per Support element other than anchor for disabled links #14291._custom.sccss
for easier, built-in variable overrides?Variables and mixins
.sr-only
a real mixin per Provide sr-only as a real mixin #13583.@extend
s in favor of mixins in more places (namely clearfixes).Grid system
max-width
for.container
? (Breaking change in 3.0.1: Nested containers don't properly size #11436)class*="col-"
).Type
dl
s (Align description lists with grid #11639).help-block
for existing utility classes and more flexible HTML Rename help-block #13267.dl-horizontal
to use grid classes instead of it's fixed-width dimensions from v3.Code
<pre>
elements per Firefox displays horizontal scrollbars on <pre> element #13917.<pre>
elements relatively unstyled (no more gray background and stuff).Utilities
!important
from.show
&.hide
(.hide and .show classes with !important breaks $(elem).show(); #9881)hide
vs.hidden
naming inconsistency (Consistency class naming #11541)_type.less
to_utilities.less
.@import
stack to work with every component possible (instead of individual state classes)?Tables
.table-condensed
to.table-sm
(Rename .table-condensed to .table-sm (for v4) #10987).table-danger
instead oftd.danger
Forms
Labels
label
styles to a class so that they're not global, per IE8 - Long <label>s overflow container (words do not wrap) #13141Inputs
min-height
on inputs since we can drop IE8 (IE8 and box-sizing don't mix well)?Validation and states
.has-error
to.has-danger
for uniformity.Layout
.form-horizontal
class entirely in favor of just grid classes.Misc
<legend>
stylingButtons
.btn-outline
Button groups
Glyphicons
Alerts
<h4>
as alert heading (Alert headings #11450)Breadcrumb
Carousel
carousel-
prefix to Carousel's.next
,.prev
,.left
,.right
classesDropdown
.dropdown-menu.pull-right
styles. We have.dropdown-menu-right
/-left
now.Input groups
:first-child
and:last-child
for-of-type
selectors: Useof-type
in Input Groups instead ofchild
#12687.Jumbotron
.display-1
).Labels
Modal
body
padding, but rather the padding on a specific set of classes.Nav
>
selectors.Navbar
Panels
Popover/tooltip
.tooltip-arrow
vs. Popover's.arrow
:before
/:after
.Progress
<progress>
variation to ensure animated backgrounds can still be used.List group
a.list-group-item
to.list-group-item-link
JS
Global
hide.bs.tooltip
->bs.tooltip.hide
, etc.) (Use a more individual event namespace #10848).js-
classes ordata
attributes for JS behavior only per Allow For Custom Indicators Selector To Be Passed To Carousel Constructor #14431keyboard
option to carousel #14590)BS
or$.BS
)BS.Popover
)BS.utils
)#foo.bar
originalEvent
property: Have Bootstrap plugin events forward the underlying originalEvent that caused them #15393tooltip.js
andall-bootstrap-plugins.min.js
are loaded.container: 'body'
is currently required)MutationObserver
to improve tooltips (Firefox hangs on to tooltip after the item has been disabled and/or destroyed #15632) and modals (Modal backdrop does not disappear, when modal-dialog being removed in HTML #16320)Affix
position: sticky
polyfill?Alert
Buttons
.btn-groups
to support my second point.change
event of associated<input>
s? have Button plugin listen for & react tochange
event of associated <input>s? #13261Carousel
Collapse
parent
option is dependent on dom structure #10966toggle
option to false when initializing: Collapse initial state problem #12254 (comment)Dropdowns
container
option) to prevent a number of parent cropping issues (due tooverflow
). Split Button in navbar shows behind menu when in small screen mode #10017, Split button dropdowns issue #12122, Dropdown in responsive table in panel -> Android browser problem with y-overflow #13214, Dropdown can open offscreen laterally #13477Scrollspy
Tab
Tooltips
display: none
per Consider making .tooltip('show') throw an error when the target isdisplay: none
#14155Popovers
Docs
compatibility= 'ie8'
from clean-css>= 31
(latest ESR). See Update the Firefox ESR version #14981.Customizer
Examples