Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.input-group .btn height when @font-size-base was changed #13171

Closed
egy186 opened this issue Mar 25, 2014 · 3 comments
Closed

.input-group .btn height when @font-size-base was changed #13171

egy186 opened this issue Mar 25, 2014 · 3 comments
Labels

Comments

@egy186
Copy link

egy186 commented Mar 25, 2014

In Firefox 28.0 and Internet Explorer 11 (on Windows 7), .btn height is larger by 1px when @font-size-base is 16px.

see:
Firefox 28.0
Internet Explorer

I tested it with https://gist.github.com/egy186/9751751.

Adding below will fix this issue, but this may not be the best way.

.input-group-btn > .btn {
  height: @input-height-base;
}
@cvrebert cvrebert added the css label Mar 25, 2014
egy186 added a commit to egy186/bootstrap that referenced this issue Mar 25, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Jun 9, 2014
@mdo
Copy link
Member

mdo commented Jun 19, 2014

Thinking about punting this to a v4 when we switch how we size elements (from pixels to rems).

@egy186
Copy link
Author

egy186 commented Jun 23, 2014

That's cool.

@mdo
Copy link
Member

mdo commented Jul 6, 2014

Word. Punting.

@mdo mdo closed this as completed Jul 6, 2014
@mdo mdo removed this from the v3.2.1 milestone Jul 6, 2014
@mdo mdo mentioned this issue Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants