Popover's content function is executed twice

[danieldean44]

When using the content function for a popover, it seems to be executed twice when the trigger occurs.

$("#blah").popover({
                    placement: 'bottom',
                    trigger: 'click',
                    content: function () {
                        console.log("Get content");
                        return "Hi";
                    }
                });

[hnrch02]

This is intentional, AFAICT. Popover.prototype.hasContent checks if the tooltip/popover is empty and based thereon decides if it should be shown in the first place.

[zlatanvasovic]

Yes, it checks for emptyness, I don't see any point of this issue.

[cvrebert]

Possibly we could rework things so that the function is only called once. (It might be an expensive function.)

[zlatanvasovic]

Yes.

2014-02-11 7:50 GMT+01:00 Chris Rebert notifications@github.com:

Possibly we could rework things so that the function is only called once.
(It might be an expensive function.)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12563#issuecomment-34730180
.

Zlatan Vasović - ZDroid

[apaulo]

Hi,

If I understand correctly, this will be addressed in Bootstrap v.3.2.0.

In the meantime, is there a turnaround? I am running an AJAX call on content: function() and I'd like to have it run only once...

Of course, I can go via the "show.bs.popover" event, but is there an easier / cleaner way?

(excuse my english, it is a foreign language to me)

[fat]

Yep, the popover function isn't cached. If you want cacheing, you should just do it yourself locally :)

$('[data-toggle="tooltip"]').tooltip({
  title: function () {
    if (this.cache) return this.cache

    // otherwise do a bunch of crazy string
    // manipulation and whatever else

    return this.cache = 'hello'
  }.bind({})
})

[cvrebert]

I still think that calling the content function twice violates the Principle of Least Surprise.

[danieldean44]

Yeah - I agree. Why was this closed? Why can't the "check for emptyness" store the content in a variable and reuse it?

[shayneoneill]

Could this behavior at least be documented in the main instructions. Its fairly bamboozling behavior if its not expected. I'm not sure this really should be a closed issue until its either corrected or documented!

[hnrch02]

Reopening since we ought to document this.

[rasmuschristensen]

A quickfix could be to ensure you have a title in the popover, then this won't happen. Not a beauty, but instead of changing the source.....
When I trigger my popover to load $getJSON I immediatly efter returns a string "loading.....", I would actually have expected this string to show up and fix the issue until the request returned and I could replace the content.....but it don't?

[AdamStelmaszczyk]

When title or content is empty, the function in content is executed twice. This is VERY surprising. I'm lucky that my friend spotted it, I haven't even noticed it.

My use case was that after the click I was replacing the content. So, the only way to get rid of duplicated, costly AJAX request (which was in the content function) was to set the title and that was my workaround. But, I don't want the title, it looked better without. It's only poor workaround.

It shouldn't work like this that in order to NOT have double request (which is a "feature" that nobody wants) I have to set... a title. It's totally not connected logically, it's bug from my perspective and should be fixed. That callback, no matter what, should be executed only once, like other 99,9%, normal callbacks out there.

[rubystar]

+1

[cvrebert]

Locking since this is already on our list for reconsideration in Bootstrap v4.