Fix #12563: Elaborate that popover('show') checks title/content #14716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already documented on line 6 of the file, but it seems reasonable to repeat it. |
| @@ -246,7 +246,7 @@ <h2 id="popovers-usage">Usage</h2> | |||
| <p>Initializes popovers for an element collection.</p> | |||
|
|
|||
| <h4>.popover('show')</h4> | |||
| <p>Reveals an element's popover.</p> | |||
| <p>Reveals an element's popover. Method will check if title or content exists before displaying.</p> | |||
There was a problem hiding this comment.
For clarity, I would suggest using the phrasing of the existing note.
blankmaker
force-pushed
the
docs/fix-12563
branch
from
e884fac to
6fa7495
Compare
cvrebert
added a commit
that referenced
this pull request
Oct 2, 2014
Fix #12563: Elaborate that popover('show') checks title/content
|
Thanks! |
|
Anytime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12563: Explain in Popover docs that the
showmethod will check to see if the element's title or content exists before displaying.This seemed like the only logical place for it since it should only happen if the
showmethod is invokved.Another possible place is in the
contentsection under Options, but it didn't seem right to explain here that the function would execute twice ifshowis invoked and the title doesn't exist.