Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sr-only as a real mixin #13583

Closed
stof opened this issue May 13, 2014 · 3 comments
Closed

Provide sr-only as a real mixin #13583

stof opened this issue May 13, 2014 · 3 comments

Comments

@stof
Copy link
Contributor

stof commented May 13, 2014

Currently, the .sr-only rules are mixinable in other selectors, but they are provided in scaffolding.less. Could it be possible to provide a real mixin for it and then use it in the class, as done for .clearfix and .text-hide ? This would allow using it when importing the Bootstrap mixins into our own less files

@cvrebert cvrebert added this to the v3.2.1 milestone May 13, 2014
@fubarhouse
Copy link

+1 - This would simplify the process of making specific items screen-reader only.
This would promote (widely) the ease and use of accessibility - not that I have a problem with using a class.

Though, there's nothing stopping you from making your own mixin...

@mdo
Copy link
Member

mdo commented Jun 20, 2014

There are problems with both those classes and mixins you mention. One doubles everything because of a Less bug and the other has two different names, one for the mixin and one for the class because of backward compatibility. Not sure what direction I'd like to go other than to perhaps punt this to v4.

@cvrebert cvrebert added this to the v4.0.0 milestone Jul 6, 2014
@mdo
Copy link
Member

mdo commented Jul 7, 2014

Punting to v4.

@mdo mdo closed this as completed Jul 7, 2014
@mdo mdo removed this from the v4.0.0 milestone Jul 7, 2014
mdo added a commit that referenced this issue May 29, 2015
…e them to create classes in _utilities.scss
@mdo mdo mentioned this issue Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants