Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.btn-link.active shouldn't be box-shadowed #14310

Closed
b1rdex opened this issue Aug 4, 2014 · 4 comments
Closed

.btn-link.active shouldn't be box-shadowed #14310

b1rdex opened this issue Aug 4, 2014 · 4 comments
Labels
Milestone

Comments

@b1rdex
Copy link

b1rdex commented Aug 4, 2014

How to reproduce: <button class="btn btn-link active">test</button> and you got very bad looking box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.125) on it. Works bad for <a> too. Here is screenshot:

image

Can be fixed with :none:

.btn.active
   box-shadow: none
   &:not(.btn-link)
     box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.125)
@djch
Copy link

djch commented Aug 4, 2014

I'm not really sure what the use case would be for making a btn-link look active. That said it would be pretty easy to add .active to the same declaration which resets the box-shadow for :active.

https://github.com/twbs/bootstrap/blob/master/less/buttons.less#L93-L99

@b1rdex
Copy link
Author

b1rdex commented Aug 4, 2014

If this link becomes underlined on hover, why shouldn't it have active state with .active class like all the other .btns?

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 4, 2014

CC: @mdo to make the design decision

@mdo mdo added the css label Aug 4, 2014
@mdo mdo added this to the v3.2.1 milestone Aug 4, 2014
@mdo
Copy link
Member

mdo commented Aug 4, 2014

Shadow shouldn't be there.

@mdo mdo closed this as completed in 6c87895 Aug 4, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants