Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumbotron doesn't have rounded corners when inside .container-fluid #14337

Closed
aried3r opened this issue Aug 6, 2014 · 0 comments
Closed

Jumbotron doesn't have rounded corners when inside .container-fluid #14337

aried3r opened this issue Aug 6, 2014 · 0 comments
Labels
css
Milestone
v3.3.0

Comments

@aried3r
Copy link

aried3r commented Aug 6, 2014

In 6273604 .container-fluid was added back to bootstrap, but the rule for rounded corners in jumbotron.less was left unmodified, is that on purpose?

I found the following in the documentation:

To make the jumbotron full width, and without rounded corners, place it outside all .containers and instead add a .container within.

which is not what I'm doing in my case. I also couldn't find any mention of components not having rounded corners because of .container-fluid.

Demo at bootply.
@cvrebert cvrebert added the css label Aug 6, 2014
@mdo mdo added this to the v3.2.1 milestone Aug 28, 2014
@cvrebert cvrebert mentioned this issue Aug 28, 2014
Closed
@mdo mdo closed this as completed in 0a816e0 Aug 28, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#14337: Round .jumbotron corners within .container a…
81e9956 
…nd .container-fluid
zmilojko added a commit to zwr/mohican that referenced this issue Dec 13, 2015
@zmilojko
fix bootstrap jumbotron
f27e848 
As noticed on the link bellow, there is a problem when jumbotron is in
a fluid container. This fixes that and will likely be unneccessar with
the nxt bootstrap release.

twbs/bootstrap#14337

Signed-off-by: zeljko <zeljko@z-ware.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
3 participants
@mdo @cvrebert @aried3r