-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing border radius variables for small and large inputs #14511
Comments
Definitely open that PR. It's a simple change we can add I think. Unsure about timing though and if it fits into the v3.2.1 release or if we'd have to do a v3.3 for it. Maybe @cvrebert has ideas? |
One question. |
Leave it as-is and simply add the new variables. We can revisit them all in v4. |
Should I commit autogenerated files? It looks like someone else's uncommited changes appear there too. |
|
.map, .html, .js? My changes affect only |
Among those files, only |
#14542 — that's it. |
Cleaned up fix for #14511 (input border-radii variables)
There is
@input-border-radius
variable and it is used by default for.form-control
.But for
.input-sm
and.input-lg
border radiuses@border-radius-small
and@border-radius-large
are used.This means that I can reset border radius for default inputs, but for small and large inputs I have to reset radiuses globally (and that's not what I want).
I can create pull request and add
@input-border-radius-small
and@input-border-radius-large
variables having@border-radius-small
and@border-radius-large
values by default.Is it ok?
The text was updated successfully, but these errors were encountered: