Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document checkPosition method of Affix #16361

Closed
cvrebert opened this issue Apr 24, 2015 · 1 comment · Fixed by #16409
Closed

Document checkPosition method of Affix #16361

cvrebert opened this issue Apr 24, 2015 · 1 comment · Fixed by #16409
Labels
confirmed docs js
Milestone
v3.3.5

Comments

@cvrebert
Copy link
Collaborator

I think it's necessary to make this method public to accommodate use cases where other widgets affect the page's or the affixed element's positioning (example: #16356).
CC: @hnrch02 @XhmikosR for feedback
@fat
Copy link
Member

fat commented Apr 25, 2015

don't see any issue with that, sounds good 👍

@cvrebert cvrebert added this to the v3.3.5 milestone Apr 25, 2015
cvrebert added a commit that referenced this issue May 2, 2015
@cvrebert
Document Affix plugin's checkPosition method
85235c5 
Fixes #16361
Refs #16356
[skip sauce]
@cvrebert cvrebert mentioned this issue May 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs js
Projects
None yet
Milestone
v3.3.5
Development

Successfully merging a pull request may close this issue.

Document Affix plugin's checkPosition method twbs/bootstrap
2 participants
@fat @cvrebert