Pagination-sm forget @line-height-small

[Jacquelin]

Hello

The height of pagination elements is not consistent with btn-sm (29px for pagination, 30px for btn, see attach image).

pagination-sm forget '@line-height-small' !

buttons.less:133

.button-size(@padding-small-vertical; @padding-small-horizontal; @font-size-small; @line-height-small; @border-radius-small);

pagination.less:87

.pagination-size(@padding-small-vertical; @padding-small-horizontal; @font-size-small; @border-radius-small);

[kkirsche]

Pull request submitted. Thanks for the fix @Jacquelin 😃

[Jacquelin]

Thanks to you :)

[Jacquelin]

Hi @kkirsche

Your pull was reject because of error while build. I forget this :
You need to update .pagination-size function in mixins/pagination.less

.pagination-size(@padding-vertical; @padding-horizontal; @font-size; @border-radius) {

to

.pagination-size(@padding-vertical; @padding-horizontal; @font-size; @line-height; @border-radius) {

and add line-height property on span

    > span {
      padding: @padding-vertical @padding-horizontal;
      font-size: @font-size;
    }

to

    > span {
      padding: @padding-vertical @padding-horizontal;
      font-size: @font-size;
      line-height: @line-height;
    }

Sorry I can't make the pull request myself ...

[kkirsche]

@Jacquelin thanks, and no worries. One other thing is the pagination line height has to be included as well for .pagination-lg for consistency. When I put it together I just wasn't thinking and didn't pull / test local first. That should be all fixed now. Sorry about that.