Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips no longer adjust their position to stay in the viewport #17297

Closed
hnrch02 opened this issue Aug 25, 2015 · 4 comments
Closed

Tooltips no longer adjust their position to stay in the viewport #17297

hnrch02 opened this issue Aug 25, 2015 · 4 comments
Labels

Comments

@hnrch02
Copy link
Collaborator

hnrch02 commented Aug 25, 2015

v4: https://output.jsbin.com/zabazi/quiet
v3: https://output.jsbin.com/niketi/quiet

X-Ref: #17238 (comment)

@fat
Copy link
Member

fat commented Nov 15, 2015

@hnrch02 your js doesn't work in v4 example :P

@fat
Copy link
Member

fat commented Nov 15, 2015

fwiw, we definitely did drop the arrow placement stuff.

You can still do some tricky stuff with constraints…

something like this, won't allow the tip to leave the window… but it definitely wont be as nice with the arrow… but also i feel like we over engineered that tip / arrow before and as a result like almost all of the v3 issues were tooltip position related

  $('.js-btn-overflow').tooltip({
    placement: "bottom",
    constraints: [
      {
        to: 'scrollParent',
        attachment: 'together',
        pin: true
      }
    ]
  })

screen shot 2015-11-14 at 9 11 34 pm

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Nov 16, 2015

@hnrch02 your js doesn't work in v4 example :P

Fixed. Was caused by us now throwing an error when jQuery < v2 is used.

something like this, won't allow the tip to leave the window… but it definitely wont be as nice with the arrow… but also i feel like we over engineered that tip / arrow before and as a result like almost all of the v3 issues were tooltip position related

100% agree. The question is do we decidedly drop this as the default? I feel like it's not used that often and you can solve this with constraints as you showed. Maybe this is more of a documentation issue?

ping @mdo @cvrebert

@mdo
Copy link
Member

mdo commented Oct 10, 2016

Yeah, I'm fine leaving this as a dropped feature for now.

@mdo mdo closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants