Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tooltip-viewport example work #17662

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

XhmikosR
Copy link
Member

@cvrebert
Copy link
Collaborator

Won't this be relevant again once #17297 is fixed?

@XhmikosR
Copy link
Member Author

Might be if that was the intention.
I know for sure that currently it's not linked from any page nor it works
due to JS errors regarding tether.
On Sep 22, 2015 13:54, "Chris Rebert" notifications@github.com wrote:

Won't this be relevant again once #17297
#17297 is fixed?


Reply to this email directly or view it on GitHub
#17662 (comment).

@cvrebert
Copy link
Collaborator

Seems like it could at least be a good visual test, if not an example, once it's fixed.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-rm-tooltip-example branch from 6337cd1 to b6317f9 Compare September 23, 2015 06:32
@XhmikosR XhmikosR changed the title Remove the unused tooltip-viewport example. Make the tooltip-viewport example work Sep 23, 2015
@XhmikosR
Copy link
Member Author

@cvrebert: I think I fixed it by just loading tether too. Please check.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 1, 2015

So, what should I do with this @cvrebert?

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-rm-tooltip-example branch from b6317f9 to d50e4a7 Compare October 1, 2015 05:34
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 1, 2015

🚢 it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants