Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_jQueryInterface for tooltip seems to reference defunct destroy method #17611

Closed
cvrebert opened this issue Sep 16, 2015 · 1 comment
Closed

_jQueryInterface for tooltip seems to reference defunct destroy method #17611

cvrebert opened this issue Sep 16, 2015 · 1 comment
Labels
js v4
Milestone
v4.0.0-alpha.5

Comments

@cvrebert
Copy link
Collaborator

See

bootstrap/js/src/tooltip.js

Line 615 in c34fdd4

if (!data && /destroy|hide/.test(config)) {

The relevant method is now named dispose.
@cvrebert cvrebert added this to the v4.0.0-alpha.2 milestone Sep 16, 2015
@Johann-S Johann-S mentioned this issue Sep 16, 2015
Merged
@mdo mdo modified the milestones: v4.0.0-alpha.2, v4.0.0-alpha.3 Dec 8, 2015
@mdo mdo modified the milestones: v4.0.0-alpha.3, v4.0.0-alpha.4 May 8, 2016
@mdo mdo mentioned this issue Oct 10, 2016
Closed
@mdo
Copy link
Member

mdo commented Oct 10, 2016

Fixed by #17614.

@mdo mdo closed this as completed Oct 10, 2016
mdo added a commit that referenced this issue Oct 10, 2016
@mdo
Merge pull request #17614 from Johann-S/patchTooltip
259fa88 
[Fix #17611][V4] Change destroy to dispose for tooltip in _JQueryInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
v4.0.0-alpha.5
Development

No branches or pull requests
2 participants
@mdo @cvrebert