Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlined buttons have the same appearance on :active and :focus states #19199

Closed
TiGR opened this issue Feb 15, 2016 · 7 comments
Closed

Outlined buttons have the same appearance on :active and :focus states #19199

TiGR opened this issue Feb 15, 2016 · 7 comments
Labels

Comments

@TiGR
Copy link
Contributor

TiGR commented Feb 15, 2016

Slightly modified example from the docs:

<div class="btn-group" data-toggle="buttons">
  <label class="btn btn-primary-outline">
    <input type="checkbox" checked="" autocomplete="off"> Checkbox 1
  </label>
  <label class="btn btn-primary">
    <input type="checkbox" autocomplete="off"> Checkbox 2
  </label>
</div>

Once you clicked the button you can't say what is its state actually until you move your mouse pointer away (or on mobile devices - tap outside of the buttons area). So, if user have tapped some checkbox he can't really say what state is it in.

Compare this behavior with not outilined buttons.

@patrickhlauke
Copy link
Member

I'm assuming you mean in v4 ?

@TiGR
Copy link
Contributor Author

TiGR commented Feb 15, 2016

Yep, there are no outlined buttons in v3

@patrickhlauke
Copy link
Member

btw note that in your example code btn-primary-outline should be btn-outline-primary

@TiGR
Copy link
Contributor Author

TiGR commented Feb 15, 2016

My code was based on docs, it seems that outline buttons docs need to be updated.

@patrickhlauke
Copy link
Member

i need to stop looking at the out-of-sync v4-alpha site, as it seems the naming was swapped at some point. i'll make a note to check/update the docs if needed.

@patrickhlauke
Copy link
Member

just to confirm that the docs in the latest version here are up-to-date. it's just http://v4-alpha.getbootstrap.com that is quite a few commits behind.

@TiGR
Copy link
Contributor Author

TiGR commented Feb 16, 2016

@patrickhlauke I've checked the actual docs. See pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants